testnet/brain-mock
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

App engine features #1

Merged
noormohammedb merged 4 commits from app_engine_features into staging 2025-04-15 11:40:29 +00:00
Conversation 1 Commits 4 Files Changed 2 +97 -26
noormohammedb commented 2025-04-14 07:55:57 +00:00
Owner
Copy Link

allow operator to kick app contract
allow admin to report app node

cron job for app node:
Removing app node if it's offline for more than 3 hours.
Compensate app contract admin if the node is offline.

allow operator to kick app contract allow admin to report app node cron job for app node: Removing app node if it's offline for more than 3 hours. Compensate app contract admin if the node is offline.
noormohammedb added 3 commits 2025-04-14 07:55:58 +00:00 
Iterating vm and app contract to validate contract
Iterating vm and app nodes also to append report
kick contract to handle both VM and App
noormohammedb changed target branch from main to staging 2025-04-14 07:56:06 +00:00
noormohammedb requested review from ghe0 2025-04-14 07:56:21 +00:00
noormohammedb added 1 commit 2025-04-14 10:17:32 +00:00
noormohammedb added 1 commit 2025-04-14 11:12:28 +00:00 
allow access if node is in app nodes or VM nodes
ghe0 requested changes 2025-04-15 01:10:32 +00:00
src/data.rs
@ -1242,0 +1289,4 @@
pub fn find_any_contract_by_uuid(
&self,
uuid: &str,
) -> Result<(Option<VmContract>, Option<AppContract>), Error> {
ghe0 commented 2025-04-14 23:58:53 +00:00
Owner
Copy Link

returning (Option<>, Option<>) can be very confusing, but I believe it's fine at this stage. We might need to refactor all of this anyway.

returning `(Option<>, Option<>)` can be very confusing, but I believe it's fine at this stage. We might need to refactor all of this anyway.
ghe0 commented 2025-04-15 01:14:00 +00:00
Owner
Copy Link

Out of all of the PRs today, this is the only one where we should test as much as we can, cause this brain has a tendency to deadlock due to the insane amounts of mutexes. We can deploy this change together when you feel ready.

We should consider refactoring this in the near future, since we will probably use this for the next 6+ months.

Out of all of the PRs today, this is the only one where we should test as much as we can, cause this brain has a tendency to deadlock due to the insane amounts of mutexes. We can deploy this change together when you feel ready. We should consider refactoring this in the near future, since we will probably use this for the next 6+ months.
👍 1
noormohammedb merged commit 10d0b7b064 into staging 2025-04-15 11:40:28 +00:00
noormohammedb deleted branch app_engine_features 2025-04-15 11:40:29 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
ghe0
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: testnet/brain-mock#1
No description provided.
Delete Branch "app_engine_features"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?