ghe0/brain-mock
1
0
Fork 1
Code Issues Pull Requests 2 Packages Projects Releases Wiki Activity

updater branch merge #1

Merged
ghe0 merged 10 commits from updater into main 2024-12-25 22:59:18 +00:00
Conversation 0 Commits 10 Files Changed 5 +402 -45
ramrem commented 2024-12-25 20:14:49 +00:00
Collaborator
Copy Link

I rewrote the code to be basically carbon copy of newvm because idk what else I can do atp.

I rewrote the code to be basically carbon copy of newvm because idk what else I can do atp.
ramrem added 6 commits 2024-12-25 20:14:50 +00:00
ghe0 requested changes 2024-12-25 20:49:46 +00:00
brain.proto Outdated
@ -79,6 +97,8 @@ service BrainDaemonService {
rpc SendVMConfirmations (stream NewVMConfirmation) returns (Empty);
rpc DeletedVMUpdates (NodePubkey) returns (stream DeletedVMUpdate);
rpc ListVMContracts (ListVMContractsReq) returns (stream VMContract);
rpc GetUpdateVM (NodePubkey) returns (stream UpdateVMRequest);
ghe0 commented 2024-12-25 20:49:04 +00:00
Owner
Copy Link

These streams are becoming confusing and hard to read, both in the proto and also in the code. We should improve readability a bit by renaming some of the RPCs and some of the messages.

Let's do this:

service BrainDaemonService {
  rpc RegisterNode (RegisterNodeReq) returns (Empty);
  rpc GetNewVMReqs (NodePubkey) returns (stream NewVMReq);
  rpc SendNewVMResp (stream NewVMResp) returns (Empty);
  rpc GetDeleteVMReq (NodePubkey) returns (stream DeleteVMReq);
  rpc ListVMContracts (ListVMContractsReq) returns (stream VMContract);
  rpc GetUpdateVMReq (NodePubkey) returns (stream UpdateVMReq);
  rpc SendUpdateVMResp (stream UpdateVMResp) returns (Empty);
}
These streams are becoming confusing and hard to read, both in the proto and also in the code. We should improve readability a bit by renaming some of the RPCs and some of the messages. Let's do this: ``` service BrainDaemonService { rpc RegisterNode (RegisterNodeReq) returns (Empty); rpc GetNewVMReqs (NodePubkey) returns (stream NewVMReq); rpc SendNewVMResp (stream NewVMResp) returns (Empty); rpc GetDeleteVMReq (NodePubkey) returns (stream DeleteVMReq); rpc ListVMContracts (ListVMContractsReq) returns (stream VMContract); rpc GetUpdateVMReq (NodePubkey) returns (stream UpdateVMReq); rpc SendUpdateVMResp (stream UpdateVMResp) returns (Empty); } ```
ghe0 marked this conversation as resolved
ramrem added 1 commit 2024-12-25 21:08:01 +00:00
ramrem added 1 commit 2024-12-25 21:24:05 +00:00
ghe0 requested changes 2024-12-25 21:27:42 +00:00
brain.proto
@ -43,0 +54,4 @@
message UpdateVMResp {
string uuid = 1;
string timestamp = 2;
ghe0 commented 2024-12-25 21:21:43 +00:00
Owner
Copy Link

I believe timestamp is not needed in the response here. It's enough if the timestamp gets recorded in the Contract.
This also means that the contract will have two fields: created_at and updated_at.

I believe timestamp is not needed in the response here. It's enough if the timestamp gets recorded in the Contract. This also means that the contract will have two fields: `created_at` and `updated_at`.
ghe0 marked this conversation as resolved
src/data.rs Outdated
@ -202,10 +214,42 @@ impl BrainData {
self.contracts.write().unwrap().push(contract);
}
pub async fn submit_update_vmconfirmation(&self, confirmation: grpc::UpdateVmResp) {
ghe0 commented 2024-12-25 21:24:23 +00:00
Owner
Copy Link

This method really needs a new name. 😄

Maybe process_updatevmresp. This means we should check all methods in data.rs to see if they can be renamed to something that makes more sense.

This method really needs a new name. 😄 Maybe `process_updatevmresp`. This means we should check all methods in `data.rs` to see if they can be renamed to something that makes more sense.
ramrem commented 2024-12-25 21:57:05 +00:00
Author
Collaborator
Copy Link

idk, the current name is self-describtive, unlike process_updatevmresp... like process could mean to do anything

idk, the current name is self-describtive, unlike process_updatevmresp... like process could mean to do anything
ghe0 commented 2024-12-25 22:05:21 +00:00
Owner
Copy Link

Let me think about this one...

Let me think about this one...
ghe0 marked this conversation as resolved
src/data.rs
@ -205,0 +237,4 @@
return;
}
let mut contracts = self.contracts.write().unwrap();
if let Some(contract) = contracts.iter_mut().find(|c| c.uuid == confirmation.uuid) {
ghe0 commented 2024-12-25 21:25:21 +00:00
Owner
Copy Link

I believe this is where we should modify the updated_at field.

I believe this is where we should modify the `updated_at` field.
ghe0 marked this conversation as resolved
ramrem added 1 commit 2024-12-25 21:54:42 +00:00
ghe0 added 1 commit 2024-12-25 22:56:42 +00:00
ghe0 merged commit 0215be3acd into main 2024-12-25 22:59:18 +00:00
ghe0 deleted branch updater 2024-12-25 22:59:19 +00:00
ghe0 referenced this issue from a commit 2024-12-25 22:59:19 +00:00
add support for VM updates
Sign in to join this conversation.
Reviewers
No reviewers
ghe0
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: ghe0/brain-mock#1
No description provided.
Delete Branch "updater"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?