ghe0/brain-mock-clients-mocks
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

updater #1

Merged
ghe0 merged 13 commits from updater into master 2024-12-25 23:00:16 +00:00
Conversation 1 Commits 13 Files Changed 4 +192 -47
ramrem commented 2024-12-25 20:36:34 +00:00
Collaborator
Copy Link

It literally can't go wrong from here, or I will start pulling my hair out.

It literally can't go wrong from here, or I will start pulling my hair out.
ramrem added 7 commits 2024-12-25 20:36:35 +00:00
ghe0 requested changes 2024-12-25 20:50:19 +00:00
daemon-mock/src/main.rs Outdated
@ -118,0 +149,4 @@
while let Some(update_vm) = req.recv().await {
let confirmation = UpdateVmResp {
uuid: update_vm.uuid,
timestamp: chrono::Utc::now().to_rfc3339(),
ghe0 commented 2024-12-25 20:44:04 +00:00
Owner
Copy Link

The timestamp must be set from the brain, for security reasons.
Also, this does not require chrono.

Check this:

src/data.rs Line 191 in 7905c1c165
created_at: format!("{:?}", std::time::SystemTime::now()),

The timestamp must be set from the brain, for security reasons. Also, this does not require chrono. Check this: https://gitea.detee.cloud/ghe0/brain-mock/src/commit/7905c1c165ca6911ad8f3d9f83ff160b2d9dc9bb/src/data.rs#L191
ghe0 marked this conversation as resolved
ghe0 commented 2024-12-25 20:57:15 +00:00
Owner
Copy Link

send_confirmations should be renamed to send_newvm_resp, in order to improve readability.

Also, send_confirmations_update should be renamed to send_updatevm_resp.

[send_confirmations](https://gitea.detee.cloud/ghe0/brain-mock-clients-mocks/src/commit/dc8977e89b7857c701d0fc92aede1e4ec84945d2/daemon-mock/src/main.rs#L58) should be renamed to `send_newvm_resp`, in order to improve readability. Also, [send_confirmations_update](https://gitea.detee.cloud/ghe0/brain-mock-clients-mocks/src/commit/dc8977e89b7857c701d0fc92aede1e4ec84945d2/daemon-mock/src/main.rs#L161) should be renamed to `send_updatevm_resp`.
ramrem added 1 commit 2024-12-25 21:15:06 +00:00
ramrem added 1 commit 2024-12-25 21:17:26 +00:00
ramrem added 1 commit 2024-12-25 21:40:18 +00:00
ramrem added 1 commit 2024-12-25 21:55:51 +00:00
ramrem added 1 commit 2024-12-25 22:04:21 +00:00
ghe0 added 1 commit 2024-12-25 22:57:09 +00:00
ghe0 merged commit 20e1ff64fa into master 2024-12-25 23:00:16 +00:00
ghe0 deleted branch updater 2024-12-25 23:00:16 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
ghe0
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: ghe0/brain-mock-clients-mocks#1
No description provided.
Delete Branch "updater"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?