general/occlum
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add a few comments to vm subsystem

Browse Source
This commit is contained in:
Tate, Hongliang Tian 2019-01-08 23:42:44 +08:00
parent 22edefc349
commit a1ea05dc41
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/libos/src/vm/process_vm.rs
View File

@ -142,7 +142,7 @@ impl ProcessVM {
self.get_stack_vma().get_end() self.get_stack_vma().get_end()
} }
// TODO: override the mmaping of already mmaped range // TODO: support overriding the mmaping of already mmaped range
pub fn mmap(&mut self, addr: usize, size: usize, flags: VMAreaFlags) pub fn mmap(&mut self, addr: usize, size: usize, flags: VMAreaFlags)
-> Result<usize, Error> -> Result<usize, Error>
{ {
@ -211,6 +211,7 @@ impl ProcessVM {
return Ok(new_brk); return Ok(new_brk);
} }
// TODO: init the memory with zeros for the expanded area
let resize_options = { let resize_options = {
let brk_start = self.get_brk_start(); let brk_start = self.get_brk_start();
let new_heap_size = align_up(new_brk, 4096) - brk_start; let new_heap_size = align_up(new_brk, 4096) - brk_start;

1
src/libos/src/vm/vm_domain.rs
View File

@ -21,6 +21,7 @@ impl VMDomain {
pub fn resize_area(&mut self, area: &mut VMArea, options: &VMResizeOptions) pub fn resize_area(&mut self, area: &mut VMArea, options: &VMResizeOptions)
-> Result<(), Error> -> Result<(), Error>
{ {
// TODO: init memory with zeros when expanding!
self.range.resize_subrange(&mut area.range, options) self.range.resize_subrange(&mut area.range, options)
} }
} }