From a1ea05dc4142d2d544a4db00e642ad2879444c96 Mon Sep 17 00:00:00 2001 From: "Tate, Hongliang Tian" Date: Tue, 8 Jan 2019 23:42:44 +0800 Subject: [PATCH] Add a few comments to vm subsystem --- src/libos/src/vm/process_vm.rs | 3 ++- src/libos/src/vm/vm_domain.rs | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/libos/src/vm/process_vm.rs b/src/libos/src/vm/process_vm.rs index 7aecdcc6..a34dadf6 100644 --- a/src/libos/src/vm/process_vm.rs +++ b/src/libos/src/vm/process_vm.rs @@ -142,7 +142,7 @@ impl ProcessVM { self.get_stack_vma().get_end() } - // TODO: override the mmaping of already mmaped range + // TODO: support overriding the mmaping of already mmaped range pub fn mmap(&mut self, addr: usize, size: usize, flags: VMAreaFlags) -> Result { @@ -211,6 +211,7 @@ impl ProcessVM { return Ok(new_brk); } + // TODO: init the memory with zeros for the expanded area let resize_options = { let brk_start = self.get_brk_start(); let new_heap_size = align_up(new_brk, 4096) - brk_start; diff --git a/src/libos/src/vm/vm_domain.rs b/src/libos/src/vm/vm_domain.rs index 53807bee..2485cc06 100644 --- a/src/libos/src/vm/vm_domain.rs +++ b/src/libos/src/vm/vm_domain.rs @@ -21,6 +21,7 @@ impl VMDomain { pub fn resize_area(&mut self, area: &mut VMArea, options: &VMResizeOptions) -> Result<(), Error> { + // TODO: init memory with zeros when expanding! self.range.resize_subrange(&mut area.range, options) } }